netdev - Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dcd3b46-9114-b551-aa90-eaaeb2101625@arinc9.com>
Date:   Fri, 4 Feb 2022 23:14:15 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com
Subject: Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y

On 04/02/2022 18:59, Jakub Kicinski wrote:
> We generally default the vendor to y and the drivers itself
> to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> so it's not a pure "vendor selection" knob. Let's default it all
> to n.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> Happy to drop this if someone has a better patch, e.g. making
> NET_DSA_REALTEK a pure vendor knob!
> 
> CC: Luiz Angelo Daros de Luca <luizluca@...il.com>
> CC: Arınç ÜNAL <arinc.unal@...nc9.com>
> CC: linus.walleij@...aro.org
> CC: andrew@...n.ch
> CC: vivien.didelot@...il.com
> CC: f.fainelli@...il.com
> CC: olteanv@...il.com
> ---
>   drivers/net/dsa/realtek/Kconfig | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
> index 5242698143d9..b7427a8292b2 100644
> --- a/drivers/net/dsa/realtek/Kconfig
> +++ b/drivers/net/dsa/realtek/Kconfig
> @@ -12,7 +12,6 @@ menuconfig NET_DSA_REALTEK
>   config NET_DSA_REALTEK_MDIO
>   	tristate "Realtek MDIO connected switch driver"
>   	depends on NET_DSA_REALTEK
> -	default y
>   	help
>   	  Select to enable support for registering switches configured
>   	  through MDIO.
> @@ -20,14 +19,12 @@ config NET_DSA_REALTEK_MDIO
>   config NET_DSA_REALTEK_SMI
>   	tristate "Realtek SMI connected switch driver"
>   	depends on NET_DSA_REALTEK
> -	default y
>   	help
>   	  Select to enable support for registering switches connected
>   	  through SMI.
>   
>   config NET_DSA_REALTEK_RTL8365MB
>   	tristate "Realtek RTL8365MB switch subdriver"
> -	default y
>   	depends on NET_DSA_REALTEK
>   	depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO
>   	select NET_DSA_TAG_RTL8_4
> @@ -36,7 +33,6 @@ config NET_DSA_REALTEK_RTL8365MB
>   
>   config NET_DSA_REALTEK_RTL8366RB
>   	tristate "Realtek RTL8366RB switch subdriver"
> -	default y
>   	depends on NET_DSA_REALTEK
>   	depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO
>   	select NET_DSA_TAG_RTL4_A

Looks good to me.

Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>

Cheers.
Arınç