netdev - Re: [PATCH net-next 15/15] mlx5: support BIG TCP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 12:03:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Coco Li <lixiaoyan@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next 15/15] mlx5: support BIG TCP packets

Hi Eric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-BIG-TCP-implementation/20220203-095336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 52dae93f3bad842c6d585700460a0dea4d70e096
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220204/202202041153.aALvQUP0-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7561f5d66d00583e6d88fa6b2fffd868dcc82b2e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Dumazet/tcp-BIG-TCP-implementation/20220203-095336
        git checkout 7561f5d66d00583e6d88fa6b2fffd868dcc82b2e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/container_of.h:5,
                    from include/linux/kernel.h:21,
                    from include/linux/skbuff.h:13,
                    from include/linux/tcp.h:17,
                    from drivers/net/ethernet/mellanox/mlx5/core/en_tx.c:33:
   include/linux/build_bug.h:78:41: error: static assertion failed: "BITS_PER_LONG >= NR_MSG_FRAG_IDS"
      78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                         ^~~~~~~~~~~~~~
   include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
      77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
         |                                  ^~~~~~~~~~~~~~~
   include/linux/skmsg.h:41:1: note: in expansion of macro 'static_assert'
      41 | static_assert(BITS_PER_LONG >= NR_MSG_FRAG_IDS);
         | ^~~~~~~~~~~~~
   drivers/net/ethernet/mellanox/mlx5/core/en_tx.c: In function 'mlx5i_sq_xmit':
>> drivers/net/ethernet/mellanox/mlx5/core/en_tx.c:1055:86: error: 'h6' undeclared (first use in this function)
    1055 |                         memcpy(eseg->inline_hdr.start, skb->data, ETH_HLEN + sizeof(*h6));
         |                                                                                      ^~
   drivers/net/ethernet/mellanox/mlx5/core/en_tx.c:1055:86: note: each undeclared identifier is reported only once for each function it appears in


vim +/h6 +1055 drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

  1011	
  1012	void mlx5i_sq_xmit(struct mlx5e_txqsq *sq, struct sk_buff *skb,
  1013			   struct mlx5_av *av, u32 dqpn, u32 dqkey, bool xmit_more)
  1014	{
  1015		struct mlx5e_tx_wqe_attr wqe_attr;
  1016		struct mlx5e_tx_attr attr;
  1017		struct mlx5i_tx_wqe *wqe;
  1018	
  1019		struct mlx5_wqe_datagram_seg *datagram;
  1020		struct mlx5_wqe_ctrl_seg *cseg;
  1021		struct mlx5_wqe_eth_seg  *eseg;
  1022		struct mlx5_wqe_data_seg *dseg;
  1023		struct mlx5e_tx_wqe_info *wi;
  1024	
  1025		struct mlx5e_sq_stats *stats = sq->stats;
  1026		int num_dma;
  1027		u16 pi;
  1028	
  1029		mlx5e_sq_xmit_prepare(sq, skb, NULL, &attr);
  1030		mlx5i_sq_calc_wqe_attr(skb, &attr, &wqe_attr);
  1031	
  1032		pi = mlx5e_txqsq_get_next_pi(sq, wqe_attr.num_wqebbs);
  1033		wqe = MLX5I_SQ_FETCH_WQE(sq, pi);
  1034	
  1035		stats->xmit_more += xmit_more;
  1036	
  1037		/* fill wqe */
  1038		wi       = &sq->db.wqe_info[pi];
  1039		cseg     = &wqe->ctrl;
  1040		datagram = &wqe->datagram;
  1041		eseg     = &wqe->eth;
  1042		dseg     =  wqe->data;
  1043	
  1044		mlx5i_txwqe_build_datagram(av, dqpn, dqkey, datagram);
  1045	
  1046		mlx5e_txwqe_build_eseg_csum(sq, skb, NULL, eseg);
  1047	
  1048		eseg->mss = attr.mss;
  1049	
  1050		if (attr.ihs) {
  1051			if (unlikely(attr.hopbyhop)) {
  1052				/* remove the HBH header.
  1053				 * Layout: [Ethernet header][IPv6 header][HBH][TCP header]
  1054				 */
> 1055				memcpy(eseg->inline_hdr.start, skb->data, ETH_HLEN + sizeof(*h6));

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org