netdev - Re: [net-next v4 10/11] page_pool: Add a stat tracking waived pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfzZXTyQ+BNss0ji@hades>
Date:   Fri, 4 Feb 2022 09:44:29 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Joe Damato <jdamato@...tly.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        hawk@...nel.org, saeed@...nel.org, ttoukan.linux@...il.com,
        brouer@...hat.com
Subject: Re: [net-next v4 10/11] page_pool: Add a stat tracking waived pages

Hi Joe, 

On Thu, Feb 03, 2022 at 04:09:32PM -0800, Joe Damato wrote:
> Track how often pages obtained from the ring cannot be added to the cache
> because of a NUMA mismatch.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> ---
>  include/net/page_pool.h | 1 +
>  net/core/page_pool.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/include/net/page_pool.h b/include/net/page_pool.h
> index 65cd0ca..bb87706 100644
> --- a/include/net/page_pool.h
> +++ b/include/net/page_pool.h
> @@ -150,6 +150,7 @@ struct page_pool_stats {
>  			    * slow path allocation
>  			    */
>  		u64 refill; /* allocations via successful refill */
> +		u64 waive;  /* failed refills due to numa zone mismatch */
>  	} alloc;
>  };
>  #endif
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 4fe48ec..0bd084c 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -166,6 +166,7 @@ static struct page *page_pool_refill_alloc_cache(struct page_pool *pool)
>  			 * This limit stress on page buddy alloactor.
>  			 */
>  			page_pool_return_page(pool, page);
> +			this_cpu_inc_alloc_stat(pool, waive);
>  			page = NULL;
>  			break;
>  		}
> -- 
> 2.7.4
> 

Personally i'd find it easier to read if patches 1-10 were squashed in a
single commit. 

Regards
/Ilias