netdev - Re: [PATCH net] tcp: take care of mixed splice()/sendmsg(MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLpPA4c6RLWZpONXP0rrjMn__T7_yN=qsBFE8L5VwyMyg@mail.gmail.com>
Date:   Fri, 4 Feb 2022 20:20:43 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        syzbot <syzkaller@...glegroups.com>,
        Talal Ahmad <talalahmad@...gle.com>,
        Arjun Roy <arjunroy@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net] tcp: take care of mixed splice()/sendmsg(MSG_ZEROCOPY)
 case

On Fri, Feb 4, 2022 at 8:06 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  3 Feb 2022 14:55:47 -0800 Eric Dumazet wrote:
> > +             if (!sk_wmem_schedule(sk, extra))
> > +                     return ENOMEM;
>
> Let me make this negative when applying, looks like an inconsequential
> typo with current callers.

Agreed, at first I was returning 0/1, and changed the 1 to ENOMEM at
the last moment.

Thanks !