netdev - Re: [PATCH v4 net-next 3/7] net: ipv4: use kfree_skb_reason() in ip_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a561b4c-1ed2-4090-34a2-09bf7908c5b4@gmail.com>
Date:   Sun, 6 Feb 2022 12:49:02 -0700
From:   David Ahern <dsahern@...il.com>
To:     menglong8.dong@...il.com, dsahern@...nel.org, kuba@...nel.org
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, pablo@...filter.org, kadlec@...filter.org,
        fw@...len.de, edumazet@...gle.com, alobakin@...me, ast@...nel.org,
        imagedong@...cent.com, pabeni@...hat.com, keescook@...omium.org,
        talalahmad@...gle.com, haokexin@...il.com,
        ilias.apalodimas@...aro.org, memxor@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        paulb@...dia.com, cong.wang@...edance.com, mengensun@...cent.com
Subject: Re: [PATCH v4 net-next 3/7] net: ipv4: use kfree_skb_reason() in
 ip_rcv_core()

On 2/5/22 12:47 AM, menglong8.dong@...il.com wrote:
> From: Menglong Dong <imagedong@...cent.com>
> 
> Replace kfree_skb() with kfree_skb_reason() in ip_rcv_core(). Three new
> drop reasons are introduced:
> 
> SKB_DROP_REASON_OTHERHOST
> SKB_DROP_REASON_IP_CSUM
> SKB_DROP_REASON_IP_INHDR
> 
> Signed-off-by: Menglong Dong <imagedong@...cent.com>
> ---
> v4:
> - stop making assumptions about the value of
>   SKB_DROP_REASON_NOT_SPECIFIED
> 
> v3:
> - add a path to SKB_DROP_REASON_PKT_TOO_SMALL
> 
> v2:
> - remove unrelated cleanup
> - add document for introduced drop reasons
> ---
>  include/linux/skbuff.h     |  9 +++++++++
>  include/trace/events/skb.h |  3 +++
>  net/ipv4/ip_input.c        | 12 ++++++++++--
>  3 files changed, 22 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>