netdev - Re: [PATCH v6 net-next] net: drop_monitor: support drop reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207094301.5c061d23@gandalf.local.home>
Date:   Mon, 7 Feb 2022 09:43:01 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     menglong8.dong@...il.com
Cc:     kuba@...nel.org, dsahern@...nel.org, idosch@...sch.org,
        nhorman@...driver.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH v6 net-next] net: drop_monitor: support drop reason

On Sat,  5 Feb 2022 16:17:38 +0800
menglong8.dong@...il.com wrote:

> --- a/net/core/drop_monitor.c
> +++ b/net/core/drop_monitor.c
> @@ -48,6 +48,16 @@
>  static int trace_state = TRACE_OFF;
>  static bool monitor_hw;
>  
> +#undef EM
> +#undef EMe
> +
> +#define EM(a, b)	[a] = #b,
> +#define EMe(a, b)	[a] = #b
> +
> +static const char *drop_reasons[SKB_DROP_REASON_MAX + 1] = {

Do you need to define the size above? Can't the compiler do it for you?

static const char *drop_reasons[] = {

-- Steve

> +	TRACE_SKB_DROP_REASON
> +};
> +
>  /* net_dm_mutex
>   *