netdev - Re: [PATCH net-next] ref_tracker: remove filter_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 08:00:00 +0100
From:   Marco Elver <elver@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH net-next] ref_tracker: remove filter_irq_stacks() call

On Sat, 5 Feb 2022 at 18:27, Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
> in stack_depot_save()") it became unnecessary to filter the stack
> before calling stack_depot_save().
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Marco Elver <elver@...gle.com>

Reviewed-by: Marco Elver <elver@...gle.com>


> Cc: Alexander Potapenko <glider@...gle.com>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> ---
>  lib/ref_tracker.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
> index 9c0c2e09df666d19aba441f568762afbd1cad4d0..dc7b14aa3431e2bf7a97a7e78220f04da144563d 100644
> --- a/lib/ref_tracker.c
> +++ b/lib/ref_tracker.c
> @@ -89,7 +89,6 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
>                 return -ENOMEM;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
>
>         spin_lock_irqsave(&dir->lock, flags);
> @@ -120,7 +119,6 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
>                 return -EEXIST;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
>
>         spin_lock_irqsave(&dir->lock, flags);
> --
> 2.35.0.263.gb82422642f-goog
>