netdev - Re: [PATCH net v2] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207183319.ls2rz4k6m7tgbqlg@mobilestation>
Date:   Mon, 7 Feb 2022 21:33:19 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Russell King <rmk+kernel@...linux.org.uk>,
        <stable@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] net: phy: marvell: Fix RGMII Tx/Rx delays setting
 in 88e1121-compatible PHYs

Hello Jakub

On Mon, Feb 07, 2022 at 09:40:39AM -0800, Jakub Kicinski wrote:
> On Sat, 5 Feb 2022 23:39:32 +0300 Pavel Parkhomenko wrote:
> > It is mandatory for a software to issue a reset upon modifying RGMII
> > Receive Timing Control and RGMII Transmit Timing Control bit fields of MAC
> > Specific Control register 2 (page 2, register 21) otherwise the changes
> > won't be perceived by the PHY (the same is applicable for a lot of other
> > registers). Not setting the RGMII delays on the platforms that imply it'
> > being done on the PHY side will consequently cause the traffic loss. We
> > discovered that the denoted soft-reset is missing in the
> > m88e1121_config_aneg() method for the case if the RGMII delays are
> > modified but the MDIx polarity isn't changed or the auto-negotiation is
> > left enabled, thus causing the traffic loss on our platform with Marvell
> > Alaska 88E1510 installed. Let's fix that by issuing the soft-reset if the
> > delays have been actually set in the m88e1121_config_aneg_rgmii_delays()
> > method.
> > 
> > Fixes: d6ab93364734 ("net: phy: marvell: Avoid unnecessary soft reset")
> > Signed-off-by: Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>
> > Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> > Cc: stable@...r.kernel.org
> > 
> > ---
> > 
> > Link: https://lore.kernel.org/netdev/96759fee7240fd095cb9cc1f6eaf2d9113b57cf0.camel@baikalelectronics.ru/
> > Changelog v2:
> > - Add "net" suffix into the PATCH-clause of the subject.
> > - Cc the patch to the stable tree list.
> > - Rebase onto the latset netdev/net branch with the top commit 59085208e4a2
> > ("net: mscc: ocelot: fix all IP traffic getting trapped to CPU with PTP over IP")
> 

> This patch is valid and waiting to be reviewed & applied, right?

Right.

> I see it's marked as Superseded in patchwork, but can't track down a v3.

We had accidentally sent out a temporal v2 version before submitting this
one. The failed patch is here
Link: https://lore.kernel.org/stable/20220205190814.20282-1-Pavel.Parkhomenko@baikalelectronics.ru/
But the message was sent to Russel and to the stable mailing list only
with no netdev list being in Cc. I thought if the right v2 was sent
out after the failed one, then even if patchwork somehow gets to catch
both of the messages, the former patch would have at least superseded
the later one. It appears I was wrong. Sorry about that. Do you want
us to resend this patch as v3 to have a proper patchwork status?

-Sergey