lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Feb 2022 15:05:22 +0100 From: Andrew Lunn <andrew@...n.ch> To: Hans Schultz <schultz.hans@...il.com> Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, Hans Schultz <schultz.hans+netdev@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: Add support for bridge port locked feature On Mon, Feb 07, 2022 at 11:07:41AM +0100, Hans Schultz wrote: > Supporting bridge port locked mode using the 802.1X mode in Marvell > mv88e6xxx switchcores is described in the '88E6096/88E6097/88E6097F > Datasheet', sections 4.4.6, 4.4.7 and 5.1.2.1 (Drop on Lock). This implementation seems to be incorrect for 6390X, and maybe others. I just picked a modern devices at random, and it is different, so didn't check any other devices. The 6390X uses bits 14 and 15, not just bit 14. So either you need to narrow down support to just those devices this actually works for, or you need to add implementations for all generations, via an op in mv88e6xxx_ops. Andrew
Powered by blists - more mailing lists