netdev - Re: [PATCH v2 1/2] net: phy: micrel: add Microchip KSZ 9897 Switch PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgGrNWeq6A7Rw3zG@lunn.ch>
Date:   Tue, 8 Feb 2022 00:28:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Enguerrand de Ribaucourt 
        <enguerrand.de-ribaucourt@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH v2 1/2] net: phy: micrel: add Microchip KSZ 9897 Switch
 PHY support

> +	/* KSZ8081A3/KSZ8091R1 PHY and KSZ9897 switch share the same
> +	 * exact PHY ID. However, they can be told apart by the default value
> +	 * of the LED mode. It is 0 for the PHY, and 1 for the switch.
> +	 */
> +	ret &= (MICREL_KSZ8081_CTRL2_LED_MODE0 | MICREL_KSZ8081_CTRL2_LED_MODE1);
> +	if (!ksz_8081)
> +		return ret;
> +	else
> +		return !ret;

What exactly does MICREL_KSZ8081_CTRL2_LED_MODE0 and
MICREL_KSZ8081_CTRL2_LED_MODE1 mean? We have to be careful in that
there could be use cases which actually wants to configure the
LEDs. There have been recent discussions for two other PHYs recently
where the bootloader is configuring the LEDs, to something other than
their default value.

      Andrew