netdev - Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220208170229.6taqduofrldbonu3@skbuf>
Date:   Tue, 8 Feb 2022 17:02:30 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Colin Foster <colin.foster@...advantage.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for
 stats

On Tue, Feb 08, 2022 at 08:49:52AM -0800, Colin Foster wrote:
> On Tue, Feb 08, 2022 at 03:45:15PM +0000, Vladimir Oltean wrote:
> > On Tue, Feb 08, 2022 at 07:41:56AM -0800, Colin Foster wrote:
> > > I see that now. It is confusing and I'll clear it up. I never caught
> > > this because I'm testing in a setup where port 0 is the CPU port, so I
> > > can't get ethtool stats. Thanks!
> > 
> > You can retrieve the stats on the CPU port, as they are appended to the
> > ethtool stats of the DSA master, prefixed with "p%02d_", cpu_dp->index.
> > 
> > ethtool -S eth0 | grep -v ': 0' # where eth0 is the DSA master
> 
> Thanks for this hint. I didn't even think to go looking for it since the
> DSA Documenation mentions an "inability to fetch CPU port statistics
> counters using ethtool." I see now that this bullet point is from 2015,
> and probably should be removed entirely.

Yes, that paragraph did not age well, although it is still true in some
sense, just not in that phrasing. You still cannot collect ethtool
statistics for cascade (DSA) ports. Maybe it should be updated.