netdev - Re: [PATCH bpf-next] bpf, x86_64: fail gracefully on bpf_jit_binary_pack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A5912F45-61A9-4D58-9787-C63CFBBD8DD7@fb.com>
Date:   Tue, 8 Feb 2022 17:34:10 +0000
From:   Song Liu <songliubraving@...com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:     Song Liu <song@...nel.org>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "Kernel Team" <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf, x86_64: fail gracefully on
 bpf_jit_binary_pack_finalize failures



> On Feb 8, 2022, at 9:28 AM, Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
> 
> On Mon, Feb 7, 2022 at 10:26 PM Song Liu <song@...nel.org> wrote:
>> 
>> Instead of BUG_ON(), fail gracefully and return orig_prog.
>> 
>> Fixes: 1022a5498f6f ("bpf, x86_64: Use bpf_jit_binary_pack_alloc")
>> Signed-off-by: Song Liu <song@...nel.org>
>> ---
>> arch/x86/net/bpf_jit_comp.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
>> index 643f38b91e30..08e8fd8f954a 100644
>> --- a/arch/x86/net/bpf_jit_comp.c
>> +++ b/arch/x86/net/bpf_jit_comp.c
>> @@ -2380,7 +2380,11 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
>>                         *
>>                         * Both cases are serious bugs that we should not continue.
> 
> I tweaked that comment a bit, since it's no longer accurate and
> pushed to bpf-next.
> Thanks!

Thanks for the fix! I had that in mind initially, but forgot about it
when I got to the keyboard. 

Song