netdev - Re: [PATCH iproute2-next] tunnel: Fix missing space after local/remote print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 09:57:29 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Gal Pressman <gal@...dia.com>
Cc:     David Ahern <dsahern@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2-next] tunnel: Fix missing space after
 local/remote print

On Tue, 8 Feb 2022 16:40:05 +0200
Gal Pressman <gal@...dia.com> wrote:

> The cited commit removed the space after the local/remote tunnel print
> and resulted in "broken" output:
> 
> gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
> Signed-off-by: Gal Pressman <gal@...dia.com>
> ---
>  ip/tunnel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ip/tunnel.c b/ip/tunnel.c
> index f2632f43babf..7200ce831317 100644
> --- a/ip/tunnel.c
> +++ b/ip/tunnel.c
> @@ -299,6 +299,8 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
>  	}
>  
>  	print_string_name_value(name, value);
> +	if (!is_json_context())
> +		print_string(PRINT_FP, NULL, " ", NULL);

is_json_context is not needed here.