netdev - Re: [PATCH bpf-next 1/2] bpf: Make remote_port field in struct bpf_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 12:58:53 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     kernel test robot <lkp@...el.com>, bpf <bpf@...r.kernel.org>,
        kbuild-all@...ts.01.org,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        kernel-team <kernel-team@...udflare.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: Make remote_port field in struct
 bpf_sk_lookup 16-bit wide

On Tue, Feb 8, 2022 at 12:42 PM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> On Tue, Feb 08, 2022 at 08:28 PM CET, Alexei Starovoitov wrote:
> > On Mon, Feb 7, 2022 at 2:05 PM kernel test robot <lkp@...el.com> wrote:
> >> 7c32e8f8bc33a5f Lorenz Bauer 2021-03-03  1148
> >> 7c32e8f8bc33a5f Lorenz Bauer 2021-03-03 @1149   if (user_ctx->local_port > U16_MAX || user_ctx->remote_port > U16_MAX) {
> >
> > Jakub,
> > are you planning to respin and remove that check?
>
> Yes, certainly. Just didn't get to it today.
>
> Can either respin the series or send a follow-up. Whatever works.

I think respin is better.