netdev - Re: [PATCH net-next 11/11] net: remove default_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+EQx3AqvE39HOjiS0F5a3_CfWqirN1cEuZYyDgxfQBDg@mail.gmail.com>
Date:   Mon, 7 Feb 2022 20:38:42 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next 11/11] net: remove default_device_exit()

On Mon, Feb 7, 2022 at 8:29 PM David Ahern <dsahern@...il.com> wrote:
>
> On 2/7/22 9:17 AM, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > For some reason default_device_ops kept two exit method:
> >
> > 1) default_device_exit() is called for each netns being dismantled in
> > a cleanup_net() round. This acquires rtnl for each invocation.
> >
> > 2) default_device_exit_batch() is called once with the list of all netns
> > int the batch, allowing for a single rtnl invocation.
> >
> > Get rid of the .exit() method to handle the logic from
> > default_device_exit_batch(), to decrease the number of rtnl acquisition
> > to one.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > ---
> >  net/core/dev.c | 22 ++++++++++++++--------
> >  1 file changed, 14 insertions(+), 8 deletions(-)
> >
>
> Reviewed-by: David Ahern <dsahern@...nel.org>

Thanks for the review !

I am sending a v2, with your tags, plus the RTNL_ASSERT() typo fixed.