netdev - Re: [PATCH bpf-next v2 2/3] libbpf: Add "libbpversion" make target to print version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 16:35:38 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Quentin Monnet <quentin@...valent.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 2/3] libbpf: Add "libbpversion" make target to
 print version

On Tue, Feb 8, 2022 at 4:06 AM Quentin Monnet <quentin@...valent.com> wrote:
>
> Add a target to libbpf's Makefile to print its version number, in a
> similar way to what running "make kernelversion" at the root of the
> repository does.
>
> This is to avoid re-implementing the parsing of the libbpf.map file in
> case some other tools want to extract the version of the libbpf sources
> they are using.
>
> Signed-off-by: Quentin Monnet <quentin@...valent.com>
> ---
>  tools/lib/bpf/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index b8b37fe76006..91136623edf9 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -108,6 +108,9 @@ MAKEOVERRIDES=
>
>  all:
>
> +libbpfversion:

I don't think we need it (see next patch), but if we end up keeping
it, please call it just "version". Worst case, "libbpf-version" seems
better still.

> +       @echo $(LIBBPF_VERSION)
> +
>  export srctree OUTPUT CC LD CFLAGS V
>  include $(srctree)/tools/build/Makefile.include
>
> --
> 2.32.0
>