netdev - Re: [PATCH nf] selftests: netfilter: fix exit value for nft_concat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgOSpXdxuZ07zJH4@salvia>
Date:   Wed, 9 Feb 2022 11:08:37 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH nf] selftests: netfilter: fix exit value for
 nft_concat_range

On Wed, Feb 09, 2022 at 10:57:35AM +0100, Stefano Brivio wrote:
> On Wed,  9 Feb 2022 16:25:51 +0800
> Hangbin Liu <liuhangbin@...il.com> wrote:
> 
> > When the nft_concat_range test failed, it exit 1 in the code
> > specifically.
> > 
> > But when part of, or all of the test passed, it will failed the
> > [ ${passed} -eq 0 ] check and thus exit with 1, which is the same
> > exit value with failure result. Fix it by exit 0 when passed is not 0.
> 
> Oops, right, thanks for fixing this!
>  
> > Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Applied, thanks