netdev - RE: [v1,net-next 3/3] net:enetc: enetc qos using the CBDR dma alloc function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Feb 2022 12:10:41 +0000
From:   Po Liu <po.liu@....com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tim.gardner@...onical.com" <tim.gardner@...onical.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
CC:     Xiaoliang Yang <xiaoliang.yang_1@....com>
Subject: RE: [v1,net-next 3/3] net:enetc: enetc qos using the CBDR dma alloc
 function


> -----Original Message-----
> From: Po Liu <po.liu@....com>
> Sent: 2022年2月9日 13:49
> To: davem@...emloft.net; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org; tim.gardner@...onical.com; kuba@...nel.org;
> Claudiu Manoil <claudiu.manoil@....com>; Vladimir Oltean
> <vladimir.oltean@....com>
> Cc: Xiaoliang Yang <xiaoliang.yang_1@....com>; Po Liu <po.liu@....com>
> Subject: [v1,net-next 3/3] net:enetc: enetc qos using the CBDR dma alloc
> function
> 
> Now we can use the enetc_cbd_alloc_data_mem() to replace complicated
> DMA data alloc method and CBDR memory basic seting.
> 
> Signed-off-by: Po Liu <po.liu@....com>
> ---
>  .../net/ethernet/freescale/enetc/enetc_qos.c  | 91 +++++--------------
>  1 file changed, 21 insertions(+), 70 deletions(-)
> 
> 
>  	memset(si_data, 0, data_size);
> 
> -	cbd.length = cpu_to_le16(data_size);
> -
> -	cbd.addr[0] = cpu_to_le32(lower_32_bits(dma_align));
> -	cbd.addr[1] = cpu_to_le32(upper_32_bits(dma_align));
> -

Sorry, found there is hardware setting bug here. Will update soon for v2.

>  	/* VIDM default to be 1.
>  	 * VID Match. If set (b1) then the VID must match, otherwise
>  	 * any VID is considered a match. VIDM setting is only used @@ -562,8
> +537,7 @@ static int enetc_streamid_hw_set(struct enetc_ndev_priv *priv,