netdev - Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgPjgvlVkykx1e1G@lunn.ch>
Date:   Wed, 9 Feb 2022 16:53:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531

On Wed, Feb 09, 2022 at 10:39:47PM +0800, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:

Is the PHY actually internal? If so PHY_INTERFACE_MODE_INTERNAL would
be correct.

Are you fixing the wrong thing here?

    Andrew