netdev - Re: [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgM09mGTZv3U5nBT@robh.at.kernel.org>
Date:   Tue, 8 Feb 2022 21:28:54 -0600
From:   Rob Herring <robh@...nel.org>
To:     Alexander Stein <alexander.stein@...tq-group.com>
Cc:     Joakim Zhang <qiangqing.zhang@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells /
 nvmem-cell-names properties

On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@...e0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..73616924fa29 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,10 @@ properties:
>  
>    mac-address: true
>  
> +  nvmem-cells: true

Need to define how many.

> +
> +  nvmem-cell-names: true

And what the names are.

> +
>    tx-internal-delay-ps:
>      enum: [0, 2000]
>  
> -- 
> 2.25.1
> 
>