netdev - Re: [PATCH net-next 0/2] net: dsa: realtek: add rtl8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfsrhgg9.fsf@bang-olufsen.dk>
Date:   Wed, 9 Feb 2022 21:34:46 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 0/2] net: dsa: realtek: add rtl8_4t tag

Hi Luiz,

Luiz Angelo Daros de Luca <luizluca@...il.com> writes:

> This DSA tag might not be useful in production as the conduit driver
> might generate a broken checksum. It is useful, though, for test
> purpose.

You make it sound like the code is never useful in production, but is
that really the case? And what kind of test case do you have in mind?

Also, you call this "tailing" which sounds quite off. Do you mean
"trailing"? I think that is the more common terminology.

In any case the series looks fine :-)

Acked-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Kind regards,
Alvin