netdev - Re: one question about your patch "vhost: log dirty page correctly"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACGkMEt6fU0s9wspqChJYiE-HPxXEbzsdKdksL8f0X8NNO-=LQ@mail.gmail.com>
Date:   Wed, 9 Feb 2022 12:21:35 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Xingyu Li <xli399@....edu>, netdev <netdev@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>,
        virtualization <virtualization@...ts.linux-foundation.org>
Subject: Re: one question about your patch "vhost: log dirty page correctly"

Adding lists.

On Wed, Feb 9, 2022 at 4:58 AM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Tue, Feb 08, 2022 at 11:37:00AM -0800, Xingyu Li wrote:
> > Hi Jason,
> >
> > Sorry to disturb you. I have a question about your Linux kernel
> > patch-- 1981e4c9a97("vhost: log dirty page correctly"). I noted that the commit
> > message says that the fix tag of this patch is 6b1e6cc7855b ("vhost: new device
> > IOTLB API"). It also says that the bug occured when try to log GIOVA.However,
> > when I look at the the commit diff of the 6b1e6cc7855b, I do not find the
> > related contents to modify the vhost_log_write() or some log-related functions.
> > Can you give me some guidance on this?

So the logic is: 6b1e6cc7855b doesn't touch vhost_log_write() so the
log is wrong since vhost_log_write() is based on GPA. That's why I
wrote 1981e4c9a97 where I translated GIOVA to GPA before doing the
log.

> >
> > --
> > Yours sincerely,
> > Xingyu
>
> Pls CC mailing list on questions. I have a policy against replying
> off list.

Right.

Thanks

>
> Thanks!
>
> --
> MST
>