netdev - Re: [PATCH] can: isotp: fix error path in isotp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220209074610.dstzmwloiqr4qfwc@pengutronix.de>
Date:   Wed, 9 Feb 2022 08:46:10 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Oliver Hartkopp <socketcan@...tkopp.net>
Cc:     netdev@...r.kernel.org, linux-can@...r.kernel.org,
        Ziyang Xuan <william.xuanziyang@...wei.com>
Subject: Re: [PATCH] can: isotp: fix error path in isotp_sendmsg() to unlock
 wait queue

On 09.02.2022 08:36:01, Oliver Hartkopp wrote:
> Commit 43a08c3bdac4 ("can: isotp: isotp_sendmsg(): fix TX buffer concurrent
> access in isotp_sendmsg()") introduced a new locking scheme that may render
> the userspace application in a locking state when an error is detected.
> This issue shows up under high load on simultaneously running isotp channels
> with identical configuration which is against the ISO specification and
> therefore breaks any reasonable PDU communication anyway.
> 
> Fixes: 43a08c3bdac4 ("can: isotp: isotp_sendmsg(): fix TX buffer concurrent access in isotp_sendmsg()")
> Cc: Ziyang Xuan <william.xuanziyang@...wei.com>
> Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>

Applied to linux-can/testing. Added stable on Cc.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)