lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Feb 2022 17:06:10 -0800 From: Jakub Kicinski <kuba@...nel.org> To: "lina.wang" <lina.wang@...iatek.com> Cc: Paolo Abeni <pabeni@...hat.com>, Maciej Żenczykowski <maze@...gle.com>, Steffen Klassert <steffen.klassert@...unet.com>, "David S . Miller" <davem@...emloft.net>, Matthias Brugger <matthias.bgg@...il.com>, "Alexei Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "Andrii Nakryiko" <andrii@...nel.org>, Linux NetDev <netdev@...r.kernel.org>, "Kernel hackers" <linux-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>, "Martin KaFai Lau" <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Willem Bruijn <willemb@...gle.com>, Eric Dumazet <edumazet@...gle.com>, <zhuoliang@...iatek.com>, <chao.song@...iatek.com> Subject: Re: [PATCH] net: fix wrong network header length On Wed, 9 Feb 2022 18:25:07 +0800 lina.wang wrote: > We use NETIF_F_GRO_FRAGLIST not for forwarding scenary, just for > software udp gro. Whatever NETIF_F_GRO_FRAGLIST or NETIF_F_GRO_FWD, > skb_segment_list should not have bugs. > > We modify skb_segment_list, not in epbf. One point is traversing the > segments costly, another is what @Maciej said, *other* helper may have > the same problem. In skb_segment_list, it calls > skb_headers_offset_update to update different headroom, which implys > header maybe different. Process notes: - the patch didn't apply so even if the discussion concludes that the patch was good you'll need to rebase on netdev/net and repost; - please don't top post.
Powered by blists - more mailing lists