netdev - Re: [PATCH net-next 00/11] net: ping6: support basic socket cmsgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Feb 2022 11:08:33 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, lorenzo@...gle.com,
        maze@...gle.com, dsahern@...nel.org, yoshfuji@...ux-ipv6.org,
        shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 00/11] net: ping6: support basic socket cmsgs

On Wed, Feb 9, 2022 at 7:36 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Add support for common SOL_SOCKET cmsgs in ICMPv6 sockets.
> Extend the cmsg tests to cover more cmsgs and socket types.
>
> SOL_IPV6 cmsgs to follow.
>
> Jakub Kicinski (11):
>   net: ping6: remove a pr_debug() statement
>   net: ping6: support packet timestamping
>   net: ping6: support setting socket options via cmsg
>   selftests: net: rename cmsg_so_mark
>   selftests: net: make cmsg_so_mark ready for more options
>   selftests: net: cmsg_sender: support icmp and raw sockets
>   selftests: net: cmsg_so_mark: test ICMP and RAW sockets
>   selftests: net: cmsg_so_mark: test with SO_MARK set by setsockopt
>   selftests: net: cmsg_sender: support setting SO_TXTIME
>   selftests: net: cmsg_sender: support Tx timestamping
>   selftests: net: test standard socket cmsgs across UDP and ICMP sockets
>
>  net/ipv6/ping.c                             |  14 +-
>  tools/testing/selftests/net/.gitignore      |   2 +-
>  tools/testing/selftests/net/Makefile        |   3 +-
>  tools/testing/selftests/net/cmsg_sender.c   | 380 ++++++++++++++++++++
>  tools/testing/selftests/net/cmsg_so_mark.c  |  67 ----
>  tools/testing/selftests/net/cmsg_so_mark.sh |  32 +-
>  tools/testing/selftests/net/cmsg_time.sh    |  83 +++++
>  7 files changed, 499 insertions(+), 82 deletions(-)
>  create mode 100644 tools/testing/selftests/net/cmsg_sender.c
>  delete mode 100644 tools/testing/selftests/net/cmsg_so_mark.c
>  create mode 100755 tools/testing/selftests/net/cmsg_time.sh
>

Already merged, but since I was on the cc line: overall looks great to
me too. Thanks Jakub.