netdev - Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220209180113.3b3f0f5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 9 Feb 2022 18:01:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     patchwork-bot+netdevbpf@...nel.org, Qing Wang <wangqing@...o.com>,
        dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of
 do_div()

On Wed, 9 Feb 2022 21:01:35 +0100 Christophe JAILLET wrote:
> Le 09/02/2022 à 14:30, patchwork-bot+netdevbpf@...nel.org a écrit :
> > Here is the summary with links:
> >    - net: ethernet: cavium: use div64_u64() instead of do_div()
> >      https://git.kernel.org/netdev/net-next/c/038fcdaf0470
> > 
> > You are awesome, thank you!  
> 
> Hi,
> 
> I think that this patch should be reverted because do_div() and 
> div64_u64() don't have the same calling convention.
> 
> See [1]
> 
> [1]: 
> https://lore.kernel.org/linux-kernel/20211117112559.jix3hmx7uwqmuryg@pengutronix.de/

Would you mind sending a revert?