netdev - [PATCH net-next 2/4] scsi: iscsi: do not assume MAX_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220210175557.1843151-3-eric.dumazet@gmail.com>
Date:   Thu, 10 Feb 2022 09:55:55 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Coco Li <lixiaoyan@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: [PATCH net-next 2/4] scsi: iscsi: do not assume MAX_SKB_FRAGS is unsigned long

From: Eric Dumazet <edumazet@...gle.com>

We want to add a CONFIG_MAX_SKB_FRAGS option in the future,
and this will change MAX_SKB_FRAGS to an int type.

cxgbi_sock_tx_queue_up() has one pr_err() using %lu to
print SKB_WR_LIST_SIZE.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>
---
 drivers/scsi/cxgbi/libcxgbi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi/libcxgbi.h
index 3687b5c0cf905827aa4ba70fbc21d42c15e7b3f7..ccf7ea612e1281bd3a3deb9fe5246549e257cc0d 100644
--- a/drivers/scsi/cxgbi/libcxgbi.h
+++ b/drivers/scsi/cxgbi/libcxgbi.h
@@ -382,7 +382,7 @@ static inline struct sk_buff *alloc_wr(int wrlen, int dlen, gfp_t gfp)
  * length of the gather list represented by an skb into the # of necessary WRs.
  * The extra two fragments are for iscsi bhs and payload padding.
  */
-#define SKB_WR_LIST_SIZE	 (MAX_SKB_FRAGS + 2)
+#define SKB_WR_LIST_SIZE	 ((unsigned long)MAX_SKB_FRAGS + 2)
 
 static inline void cxgbi_sock_reset_wr_list(struct cxgbi_sock *csk)
 {
-- 
2.35.1.265.g69c8d7142f-goog