netdev - Re: [PATCH net-next v6 2/5] net/smc: Limit backlog connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a96cd721-4c0e-5f8c-0796-b3ee70270af5@linux.alibaba.com>
Date:   Thu, 10 Feb 2022 11:28:52 +0800
From:   "D. Wythe" <alibuda@...ux.alibaba.com>
To:     Karsten Graul <kgraul@...ux.ibm.com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v6 2/5] net/smc: Limit backlog connections



在 2022/2/10 上午12:02, Karsten Graul 写道:
> On 09/02/2022 15:11, D. Wythe wrote:
>> +static struct sock *smc_tcp_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
>> +					  struct request_sock *req,
>> +					  struct dst_entry *dst,
>> +					  struct request_sock *req_unhash,
>> +					  bool *own_req)
>> +{
>> +	struct smc_sock *smc;
>> +
>> +	smc = (struct smc_sock *)((uintptr_t)sk->sk_user_data & ~SK_USER_DATA_NOCOPY);
> 
> Did you run checkpatch.pl for these patches, for me this and other lines look longer
> than 80 characters.

The latest checkpacth removes this restriction, so I didn't find this 
problem, I'll fix it right away.

>> diff --git a/net/smc/smc.h b/net/smc/smc.h
>> index 37b2001..5e5e38d 100644
>> --- a/net/smc/smc.h
>> +++ b/net/smc/smc.h
>> @@ -252,6 +252,10 @@ struct smc_sock {				/* smc sock container */
>>   	bool			use_fallback;	/* fallback to tcp */
>>   	int			fallback_rsn;	/* reason for fallback */
>>   	u32			peer_diagnosis; /* decline reason from peer */
>> +	atomic_t                smc_pendings;   /* pending smc connections */
> 
> I don't like the name smc_pendings, its not very specific.
> What about queued_smc_hs?
> And for the comment: queued smc handshakes
> 
>> +	struct inet_connection_sock_af_ops		af_ops;
>> +	const struct inet_connection_sock_af_ops	*ori_af_ops;
>> +						/* origin af ops */
> origin -> original
>>   	int			sockopt_defer_accept;
>>   						/* sockopt TCP_DEFER_ACCEPT
>>   						 * value
> 

Copy that. I'll rename it all.