netdev - RE: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to dbg level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB336795B622887929554E63B0FC2F9@BYAPR11MB3367.namprd11.prod.outlook.com>
Date:   Thu, 10 Feb 2022 05:29:53 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Jonathan Toppins <jtoppins@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message
 to dbg level



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jonathan Toppins
> Sent: Thursday, February 3, 2022 11:15 PM
> To: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; intel-
> wired-lan@...ts.osuosl.org; David S. Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH v2] ice: change "can't set link" message to
> dbg level
> 
> In the case where the link is owned by manageability, the firmware is not
> allowed to set the link state, so an error code is returned.
> This however is non-fatal and there is nothing the operator can do, so
> instead of confusing the operator with messages they can do nothing about
> hide this message behind the debug log level.
> 
> Signed-off-by: Jonathan Toppins <jtoppins@...hat.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)