lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220211181500.1856198-4-bigeasy@linutronix.de> Date: Fri, 11 Feb 2022 19:14:56 +0100 From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> To: greybus-dev@...ts.linaro.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev, linux-usb@...r.kernel.org, netdev@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Alex Elder <elder@...nel.org>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hans de Goede <hdegoede@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Johan Hovold <johan@...nel.org>, Lee Jones <lee.jones@...aro.org>, Rui Miguel Silva <rmfrfs@...il.com>, Thomas Gleixner <tglx@...utronix.de>, UNGLinuxDriver@...rochip.com, Wolfram Sang <wsa@...nel.org>, Woojung Huh <woojung.huh@...rochip.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de> Subject: [PATCH v4 3/7] i2c: cht-wc: Use generic_handle_irq_safe(). Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Reviewed-by: Hans de Goede <hdegoede@...hat.com> Acked-by: Wolfram Sang <wsa@...nel.org> --- drivers/i2c/busses/i2c-cht-wc.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c index 1cf68f85b2e11..8ccf0c928bb44 100644 --- a/drivers/i2c/busses/i2c-cht-wc.c +++ b/drivers/i2c/busses/i2c-cht-wc.c @@ -99,15 +99,8 @@ static irqreturn_t cht_wc_i2c_adap_thread_handler(int id, void *data) * interrupt handler as well, so running the client irq handler from * this thread will cause things to lock up. */ - if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) { - /* - * generic_handle_irq expects local IRQs to be disabled - * as normally it is called from interrupt context. - */ - local_irq_disable(); - generic_handle_irq(adap->client_irq); - local_irq_enable(); - } + if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) + generic_handle_irq_safe(adap->client_irq); return IRQ_HANDLED; } -- 2.34.1
Powered by blists - more mailing lists