netdev - Re: [PATCH net-next] net: dsa: realtek: realtek-mdio: reset before setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yga8sFBosiRpfofp@lunn.ch>
Date:   Fri, 11 Feb 2022 20:44:48 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc:     netdev@...r.kernel.org, linus.walleij@...aro.org,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, kuba@...nel.org, alsi@...g-olufsen.dk,
        arinc.unal@...nc9.com, Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH net-next] net: dsa: realtek: realtek-mdio: reset before
 setup

> diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
> index ed5abf6cb3d6..e7d3e1bcf8b8 100644
> --- a/drivers/net/dsa/realtek/realtek.h
> +++ b/drivers/net/dsa/realtek/realtek.h
> @@ -5,14 +5,17 @@
>   * Copyright (C) 2009-2010 Gabor Juhos <juhosg@...nwrt.org>
>   */
>  
> -#ifndef _REALTEK_SMI_H
> -#define _REALTEK_SMI_H
> +#ifndef _REALTEK_H
> +#define _REALTEK_H
  
 
> -#endif /*  _REALTEK_SMI_H */
> +#endif /*  _REALTEK_H */

These two hunks should probably be in a separate patch.  At minimum,
please mention it is in the commit message.

       Andrew