lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Feb 2022 16:53:56 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: Simon Horman <simon.horman@...igine.com>, "David S. Miller" <davem@...emloft.net>, John Hurley <john.hurley@...ronome.com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, oss-drivers@...igine.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 1/2] nfp: flower: Fix a potential leak in nfp_tunnel_add_shared_mac() On Thu, 10 Feb 2022 23:34:52 +0100 Christophe JAILLET wrote: > ida_simple_get() returns an id between min (0) and max (NFP_MAX_MAC_INDEX) > inclusive. > So NFP_MAX_MAC_INDEX (0xff) is a valid id. > > In order for the error handling path to work correctly, the 'invalid' > value for 'ida_idx' should not be in the 0..NFP_MAX_MAC_INDEX range, > inclusive. > > So set it to -1. > > Fixes: 20cce8865098 ("nfp: flower: enable MAC address sharing for offloadable devs") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> This patch is a fix and the other one is refactoring. They can't be in the same series because they need to go to different trees. Please repost the former with [PATCH net] and ~one week later the latter with [PATCH net-next].
Powered by blists - more mailing lists