netdev - Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <263df461-1bd5-6cea-06c3-140f6da3b043@gmail.com>
Date:   Fri, 11 Feb 2022 19:50:07 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org
Cc:     linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        olteanv@...il.com, davem@...emloft.net, kuba@...nel.org,
        alsi@...g-olufsen.dk, arinc.unal@...nc9.com,
        Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before
 setup



On 2/11/2022 6:27 PM, Luiz Angelo Daros de Luca wrote:
> Some devices, like the switch in Banana Pi BPI R64 only starts to answer
> after a HW reset. It is the same reset code from realtek-smi.
> 
> In realtek-smi, only assert the reset when the gpio is defined.
> 
> Reported-by: Frank Wunderlich <frank-w@...lic-files.de>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> Tested-by: Frank Wunderlich <frank-w@...lic-files.de>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> ---
>   drivers/net/dsa/realtek/realtek-mdio.c | 19 +++++++++++++++++++
>   drivers/net/dsa/realtek/realtek-smi.c  | 17 ++++++++++-------
>   drivers/net/dsa/realtek/realtek.h      |  3 +++
>   3 files changed, 32 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
> index 0c5f2bdced9d..fa2339763c71 100644
> --- a/drivers/net/dsa/realtek/realtek-mdio.c
> +++ b/drivers/net/dsa/realtek/realtek-mdio.c
> @@ -152,6 +152,21 @@ static int realtek_mdio_probe(struct mdio_device *mdiodev)
>   	/* TODO: if power is software controlled, set up any regulators here */
>   	priv->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
>   
> +	/* Assert then deassert RESET */

This is extra nitpicky and I would not want you to submit a v3 just 
because of that, but the comment applies to the block of code after that 
one. Immediately below is when you fetch the reset line.

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian