netdev - Re: [PATCH] net: mvpp2: Check for null pcs in mvpp2_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgeEsF/cr8pfeUR4@shell.armlinux.org.uk>
Date:   Sat, 12 Feb 2022 09:58:08 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     netdev@...r.kernel.org, mw@...ihalf.com, davem@...emloft.net,
        kuba@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: Check for null pcs in mvpp2_acpi_start()

On Fri, Feb 11, 2022 at 06:18:22PM -0600, Jeremy Linton wrote:
> Hi,
> 
> On 2/11/22 17:49, Russell King (Oracle) wrote:
> > On Fri, Feb 11, 2022 at 05:42:35PM -0600, Jeremy Linton wrote:
> > > Booting a MACCHIATObin with 5.17 the system OOPs with
> > > a null pointer deref when the network is started. This
> > > is caused by the pcs->ops structure being null on this
> > > particular platform/firmware.
> > 
> > pcs->ops should never be NULL. I'm surprised this fix results in any
> > kind of working networking.
> > 
> > Instead, the initialilsation of port->pcs_*.ops needs to be moved out
> > of the if (!mvpp2_use_acpi_compat_mode(..)) block. Please try this:
> 
> That appears to fix it as well, shall I re-post this with your fix, or will
> you?

I see you re-posted it anyway - that's fine. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!