netdev - [PATCH iproute2] iplink_can: print_usage: typo fix, add missing spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Feb 2022 22:27:27 +0900
From:   Vincent Mailhol <mailhol.vincent@...adoo.fr>
To:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-can@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: [PATCH iproute2] iplink_can: print_usage: typo fix, add missing spaces

The can help menu misses three spaces for the TDCV, TDCO and TDCF
parameters, making the closing curly bracket unaligned.

For reference, before this patch:

| $ ip link help can
| Usage: ip link set DEVICE type can
| 	[ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
| 	[ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1
|  	  phase-seg2 PHASE-SEG2 [ sjw SJW ] ]
|
| 	[ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] |
| 	[ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1
|  	  dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ]
| 	[ tdcv TDCV tdco TDCO tdcf TDCF ]
|
| 	[ loopback { on | off } ]
| 	[ listen-only { on | off } ]
| 	[ triple-sampling { on | off } ]
| 	[ one-shot { on | off } ]
| 	[ berr-reporting { on | off } ]
| 	[ fd { on | off } ]
| 	[ fd-non-iso { on | off } ]
| 	[ presume-ack { on | off } ]
| 	[ cc-len8-dlc { on | off } ]
| 	[ tdc-mode { auto | manual | off } ]
|
| 	[ restart-ms TIME-MS ]
| 	[ restart ]
|
| 	[ termination { 0..65535 } ]
|
| 	Where: BITRATE	:= { NUMBER in bps }
| 		  SAMPLE-POINT	:= { 0.000..0.999 }
| 		  TQ		:= { NUMBER in ns }
| 		  PROP-SEG	:= { NUMBER in tq }
| 		  PHASE-SEG1	:= { NUMBER in tq }
| 		  PHASE-SEG2	:= { NUMBER in tq }
| 		  SJW		:= { NUMBER in tq }
| 		  TDCV		:= { NUMBER in tc}
| 		  TDCO		:= { NUMBER in tc}
| 		  TDCF		:= { NUMBER in tc}
| 		  RESTART-MS	:= { 0 | NUMBER in ms }

... and after this patch:

| $ ip link help can
| Usage: ip link set DEVICE type can
| 	[ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
| 	[ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1
|  	  phase-seg2 PHASE-SEG2 [ sjw SJW ] ]
|
| 	[ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] |
| 	[ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1
|  	  dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ]
| 	[ tdcv TDCV tdco TDCO tdcf TDCF ]
|
| 	[ loopback { on | off } ]
| 	[ listen-only { on | off } ]
| 	[ triple-sampling { on | off } ]
| 	[ one-shot { on | off } ]
| 	[ berr-reporting { on | off } ]
| 	[ fd { on | off } ]
| 	[ fd-non-iso { on | off } ]
| 	[ presume-ack { on | off } ]
| 	[ cc-len8-dlc { on | off } ]
| 	[ tdc-mode { auto | manual | off } ]
|
| 	[ restart-ms TIME-MS ]
| 	[ restart ]
|
| 	[ termination { 0..65535 } ]
|
| 	Where: BITRATE	:= { NUMBER in bps }
| 		  SAMPLE-POINT	:= { 0.000..0.999 }
| 		  TQ		:= { NUMBER in ns }
| 		  PROP-SEG	:= { NUMBER in tq }
| 		  PHASE-SEG1	:= { NUMBER in tq }
| 		  PHASE-SEG2	:= { NUMBER in tq }
| 		  SJW		:= { NUMBER in tq }
| 		  TDCV		:= { NUMBER in tc }
| 		  TDCO		:= { NUMBER in tc }
| 		  TDCF		:= { NUMBER in tc }
| 		  RESTART-MS	:= { 0 | NUMBER in ms }

Fixes: 0c263d7c36ff ("iplink_can: add new CAN FD bittiming parameters:
Transmitter Delay Compensat ion (TDC)")
Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
---
 ip/iplink_can.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index 6ea02a2a..0e670a6c 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -53,9 +53,9 @@ static void print_usage(FILE *f)
 		"\t	  PHASE-SEG1	:= { NUMBER in tq }\n"
 		"\t	  PHASE-SEG2	:= { NUMBER in tq }\n"
 		"\t	  SJW		:= { NUMBER in tq }\n"
-		"\t	  TDCV		:= { NUMBER in tc}\n"
-		"\t	  TDCO		:= { NUMBER in tc}\n"
-		"\t	  TDCF		:= { NUMBER in tc}\n"
+		"\t	  TDCV		:= { NUMBER in tc }\n"
+		"\t	  TDCO		:= { NUMBER in tc }\n"
+		"\t	  TDCF		:= { NUMBER in tc }\n"
 		"\t	  RESTART-MS	:= { 0 | NUMBER in ms }\n"
 		);
 }
-- 
2.34.1