netdev - Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 11 Feb 2022 16:38:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon

On Fri, 11 Feb 2022 23:32:34 +0100 Linus Walleij wrote:
> If we access the syscon (expansion bus config registers) using the
> syscon regmap instead of relying on direct accessor functions,
> we do not need to call this static code in the machine
> (arch/arm/mach-ixp4xx/common.c) which makes things less dependent
> on custom machine-dependent code.
> 
> Look up the syscon regmap and handle the error: this will make
> deferred probe work with relation to the syscon.
> 
> Select the syscon in Kconfig and depend on OF so we know that
> all we need will be available.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v1->v2:
> - No changes.
> 
> Network maintainers: I'm looking for an ACK to take this
> change through ARM SoC along with other changes removing
> these accessor functions.

Acked-by: Jakub Kicinski <kuba@...nel.org>