netdev - Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iltjuevn.fsf@bang-olufsen.dk>
Date:   Sun, 13 Feb 2022 12:31:40 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
CC:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before
 setup

Arınç ÜNAL <arinc.unal@...nc9.com> writes:

> 
>> 
>> On 12 Feb 2022, at 05:27, Luiz Angelo Daros de Luca <luizluca@...il.com> wrote:
>> 
>> Some devices, like the switch in Banana Pi BPI R64 only starts to answer
>> after a HW reset. It is the same reset code from realtek-smi.
>> 
>> In realtek-smi, only assert the reset when the gpio is defined.
>
> If realtek-smi also resets before setup with this patch (I don’t understand code very well) can you mention it next to mdio in the summary too?

realtek-smi was already asserting reset. I just asked Luiz to send a
patch to only try the reset if reset-gpio is actually specified, else it
prints "asserting RESET" without actually doing it. So this is largely
cosmetic. But it is odd to touch realtek-smi when the subject is
realtek-mdio.

Arguably this could be separated into a few patches; something to
consider if you decide to send a v3 per Florian's comment:

1. realtek-smi: add if block around reset-gpio assertion
2. realtek-smi: demote dev_info to dev_dbg in reset-gpio assertion
3. realtek-mdio: add HW reset here too, based on realtek-smi (with
   dev_dbg)

Kind regards,
Alvin