netdev - Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66140ffb-306e-2956-2f6b-c017a38e18f8@collabora.com>
Date:   Mon, 14 Feb 2022 21:12:46 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Sherry Yang <sherry.yang@...cle.com>
Cc:     usama.anjum@...labora.com, Shuah Khan <skhan@...uxfoundation.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        "luto@...capital.net" <luto@...capital.net>,
        "wad@...omium.org" <wad@...omium.org>,
        "christian@...uner.io" <christian@...uner.io>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "kafai@...com" <kafai@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "yhs@...com" <yhs@...com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding
 missing headers

>> "../../../../usr/include/" directory doesn't have header files if
>> different output directory is used for kselftests build like "make -C
>> tools/tests/selftest O=build". Can you try adding recently added
>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>> easy and correct for other build combinations as well?
>>
>>
> 
> Hi Muhammad,
> 
> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice 
> work! I really appreciate you made headers inclusion compatible. However, 
> my case is a little more complicated. It will throw warnings with -I, using 
> -isystem can suppress these warnings, more details please refer to 
> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
> 
> According to this case, do you think will it be better to export header path 
> (KHDR_INCLUDES) without “-I”?
Well said. I've thought about it and it seems like -isystem is better
than -I. I've sent a patch:
https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
I'm looking forward to discussion on it.

Thanks,
Usama