netdev - Re: [PATCH bpf-next 2/3] veth: rework veth_xdp_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgrDppq+PRD7j/C8@lore-desk>
Date:   Mon, 14 Feb 2022 22:03:34 +0100
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net, brouer@...hat.com,
        toke@...hat.com, pabeni@...hat.com, echaudro@...hat.com,
        lorenzo.bianconi@...hat.com, toshiaki.makita1@...il.com,
        andrii@...nel.org
Subject: Re: [PATCH bpf-next 2/3] veth: rework veth_xdp_rcv_skb in order to
 accept non-linear skb

> On Sat, 12 Feb 2022 12:03:49 +0100 Lorenzo Bianconi wrote:
> > On Feb 11, Jakub Kicinski wrote:
> > > On Fri, 11 Feb 2022 02:20:31 +0100 Lorenzo Bianconi wrote:  
> > > > +	if (skb_shared(skb) || skb_head_is_locked(skb)) {  
> > > 
> > > Is this sufficient to guarantee that the frags can be written?
> > > skb_cow_data() tells a different story.  
> > 
> > Do you mean to consider paged part of the skb always not writable, right?
> > In other words, we should check something like:
> > 
> > 	if (skb_shared(skb) || skb_head_is_locked(skb) ||
> > 	    skb_shinfo(skb)->nr_frags) {
> > 	    ...
> > 	}
> 
> Yes, we do have skb_has_shared_frag() but IDK if it guarantees frags
> are writable :S

ack, I will add skb_shinfo(skb)->nr_frags check in v2.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)