netdev - Re: [PATCH net-next v3 1/2] net: dsa: realtek: realtek-smi: clean-up reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0e6be61-4c1f-a660-07b6-8aa0a4586a05@arinc9.com>
Date:   Mon, 14 Feb 2022 09:21:44 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org
Cc:     linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
        kuba@...nel.org, alsi@...g-olufsen.dk
Subject: Re: [PATCH net-next v3 1/2] net: dsa: realtek: realtek-smi: clean-up
 reset

On 14/02/2022 05:20, Luiz Angelo Daros de Luca wrote:
> When reset GPIO was missing, the driver was still printing an info
> message and still trying to assert the reset. Although gpiod_set_value()
> will silently ignore calls with NULL gpio_desc, it is better to make it
> clear the driver might allow gpio_desc to be NULL.
> 
> The initial value for the reset pin was changed to GPIOD_OUT_LOW,
> followed by a gpiod_set_value() asserting the reset. This way, it will
> be easier to spot if and where the reset really happens.
> 
> A new "asserted RESET" message was added just after the reset is
> asserted, similar to the existing "deasserted RESET" message. Both
> messages were demoted to dbg. The code comment is not needed anymore.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>

Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>

Arınç