netdev - Re: [PATCH V4 3/4] vhost_vdpa: don't setup irq offloading when irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Feb 2022 14:48:12 +0800
From:   "Zhu, Lingshan" <lingshan.zhu@...el.com>
To:     Jason Wang <jasowang@...hat.com>, mst@...hat.com
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH V4 3/4] vhost_vdpa: don't setup irq offloading when
 irq_num < 0



On 2/14/2022 2:28 PM, Jason Wang wrote:
>
> 在 2022/2/3 下午3:27, Zhu Lingshan 写道:
>> When irq number is negative(e.g., -EINVAL), the virtqueue
>> may be disabled or the virtqueues are sharing a device irq.
>> In such case, we should not setup irq offloading for a virtqueue.
>>
>> Signed-off-by: Zhu Lingshan <lingshan.zhu@...el.com>
>> ---
>>   drivers/vhost/vdpa.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index 851539807bc9..c4fcacb0de3a 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -96,6 +96,10 @@ static void vhost_vdpa_setup_vq_irq(struct 
>> vhost_vdpa *v, u16 qid)
>>       if (!ops->get_vq_irq)
>>           return;
>>   +    irq = ops->get_vq_irq(vdpa, qid);
>> +    if (irq < 0)
>> +        return;
>> +
>>       irq = ops->get_vq_irq(vdpa, qid);
>
>
> So the get_vq_irq() will be called twice?
yes, the latter one should be removed
>
>
>> irq_bypass_unregister_producer(&vq->call_ctx.producer);
>>       if (!vq->call_ctx.ctx || irq < 0)
>
>
> We're already checked irq against 0 here.
sure, will remove this

Thanks!
>
>
> Thanks
>
>