netdev - Re: [PATCH net-next] net/smc: return ETIMEDOUT when smc_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c85310ed-fd9c-fa8c-88d2-862b5d99dbbe@linux.ibm.com>
Date:   Tue, 15 Feb 2022 14:02:37 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     "D. Wythe" <alibuda@...ux.alibaba.com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: return ETIMEDOUT when smc_connect_clc()
 timeout

On 15/02/2022 09:24, D. Wythe wrote:
> From: "D. Wythe" <alibuda@...ux.alibaba.com>
> 
> When smc_connect_clc() times out, it will return -EAGAIN(tcp_recvmsg
> retuns -EAGAIN while timeout), then this value will passed to the
> application, which is quite confusing to the applications, makes
> inconsistency with TCP.
> 
> From the manual of connect, ETIMEDOUT is more suitable, and this patch
> try convert EAGAIN to ETIMEDOUT in that case.

You say that the sock_recvmsg() in smc_clc_wait_msg() returns -EAGAIN?
Is there a reason why you translate it in __smc_connect() and not already in
smc_clc_wait_msg() after the call to sock_recvmsg()?