netdev - Re: [PATCH v1 1/4] vdpa: Remove unsupported command line option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220215144936.GE229469@mtl-vdi-166.wap.labs.mlnx>
Date:   Tue, 15 Feb 2022 16:49:36 +0200
From:   Eli Cohen <elic@...dia.com>
To:     Si-Wei Liu <si-wei.liu@...cle.com>
CC:     <stephen@...workplumber.org>, <netdev@...r.kernel.org>,
        <jasowang@...hat.com>, <lulu@...hat.com>,
        Jianbo Liu <jianbol@...lanox.com>
Subject: Re: [PATCH v1 1/4] vdpa: Remove unsupported command line option

On Fri, Feb 11, 2022 at 04:44:14PM -0800, Si-Wei Liu wrote:
> 
> 
> On 2/10/2022 5:31 AM, Eli Cohen wrote:
> > "-v[erbose]" option is not supported.
> > Remove it.
> > 
> > Acked-by: Jason Wang <jasowang@...hat.com>
> > Reviewed-by: Jianbo Liu <jianbol@...lanox.com>
> > Signed-off-by: Eli Cohen <elic@...dia.com>
> > ---
> >   vdpa/vdpa.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> > index f048e470c929..4ccb564872a0 100644
> > --- a/vdpa/vdpa.c
> > +++ b/vdpa/vdpa.c
> > @@ -711,7 +711,7 @@ static void help(void)
> >   	fprintf(stderr,
> >   		"Usage: vdpa [ OPTIONS ] OBJECT { COMMAND | help }\n"
> >   		"where  OBJECT := { mgmtdev | dev }\n"
> > -		"       OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n");
> > +		"       OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] }\n");
> Maybe remove -n option that is also unsupported yet?

I didn't notice this. Will review all help messages and fix in a follow
up patch.

> 
> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>
> >   }
> >   static int vdpa_cmd(struct vdpa *vdpa, int argc, char **argv)
>