netdev - Re: [PATCH v2 net-next 1/8] net: bridge: vlan: notify switchdev only when something changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220215155202.vfrg2xbxtetpdk6q@skbuf>
Date:   Tue, 15 Feb 2022 15:52:02 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Roopa Prabhu <roopa@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Rafael Richter <rafael.richter@....de>,
        Daniel Klauer <daniel.klauer@....de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v2 net-next 1/8] net: bridge: vlan: notify switchdev only
 when something changed

On Tue, Feb 15, 2022 at 05:44:52PM +0200, Nikolay Aleksandrov wrote:
> > Would you mind if I added an extra patch that also does this (it would
> > also remove the need for this check in drivers, plus it would change the
> > definition of "changed" to something IMO more reasonable, i.e. a master
> > VLAN that isn't brentry doesn't really exist, so even though the
> > !BRENTRY->BRENTRY is a flag change, it isn't a change of a switchdev
> > VLAN object that anybody offloads), or is there some reason I'm missing?
> 
> I agree, patch looks good to me. I see that everyone already filters the
> !BRENTRY case anyway.

Thanks, this simplifies things quite a bit.