netdev - Re: [PATCH bpf-next v4] bpf: reject kfunc calls that overflow insn->imm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164494860978.24331.14438587212301214226.git-patchwork-notify@kernel.org>
Date:   Tue, 15 Feb 2022 18:10:09 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Hou Tao <houtao1@...wei.com>
Cc:     ast@...nel.org, yhs@...com, daniel@...earbox.net, kafai@...com,
        andrii@...nel.org, songliubraving@...com, kpsingh@...nel.org,
        davem@...emloft.net, kuba@...nel.org, john.fastabend@...il.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v4] bpf: reject kfunc calls that overflow insn->imm

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Tue, 15 Feb 2022 14:57:32 +0800 you wrote:
> Now kfunc call uses s32 to represent the offset between the address of
> kfunc and __bpf_call_base, but it doesn't check whether or not s32 will
> be overflowed. The overflow is possible when kfunc is in module and the
> offset between module and kernel is greater than 2GB. Take arm64 as an
> example, before commit b2eed9b58811 ("arm64/kernel: kaslr: reduce module
> randomization range to 2 GB"), the offset between module symbol and
> __bpf_call_base will in 4GB range due to KASLR and may overflow s32.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4] bpf: reject kfunc calls that overflow insn->imm
    https://git.kernel.org/bpf/bpf-next/c/8cbf062a250e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html