netdev - Re: [PATCH net] net: sched: limit TC_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b394f7b5-393e-d079-c909-4cb05e061655@mojatatu.com>
Date:   Tue, 15 Feb 2022 18:38:35 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] net: sched: limit TC_ACT_REPEAT loops

On 2022-02-15 12:27, Eric Dumazet wrote:
> On Mon, Feb 14, 2022 at 5:54 PM Eric Dumazet <edumazet@...gle.com> wrote:
>>
>>>> +             repeat_ttl = 10;
>>>
>>> Not sure if there is any use case of repeat action with 10+ repeats...
>>> Use a sufficiently larger one to be 100% safe?
>>
>> I have no idea of what the practical limit would be ?
>>
>> 100, 1000, time limit ?
> 
> Jamal, you already gave your Ack, but Cong is concerned about the 10 limit.
> 
> What should I used for v2 ?
> 
> Honestly I fail to see a valid reason for TC_ACT_REPEAT more than few times,
> but I have no idea of what real world actions using REPEAT look like.
> 

I havent seen more than a few. I was indifferent but maybe go for
something like 32.

cheers,
jamal