netdev - Re: [PATCH net] ipv6: per-netns exclusive flowlabel checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Feb 2022 23:15:54 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        Congyu Liu <liu3101@...due.edu>
Subject: Re: [PATCH net] ipv6: per-netns exclusive flowlabel checks

On Mon, Feb 14, 2022 at 7:19 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi Willem,
>
> Thank you for the patch! Perhaps something to improve:

>    In file included from net/sched/cls_flow.c:24:
>    In file included from include/net/ip.h:30:
>    In file included from include/net/route.h:24:
>    In file included from include/net/inetpeer.h:16:
>    include/net/ipv6.h:403:30: error: no member named 'ipv6' in 'struct net'
>                READ_ONCE(sock_net(sk)->ipv6.flowlabel_has_excl))

I'll wrap the whole function in IS_ENABLED(CONFIG_IPV6).
fl6_sock_lookup is only called from code in .c files that are
conditional on CONFIG_IPV6.