netdev - RE: [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in qed_roce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM5PR1801MB205732C84AFB0449EC342B6DB2349@DM5PR1801MB2057.namprd18.prod.outlook.com>
Date:   Tue, 15 Feb 2022 05:35:06 +0000
From:   Prabhakar Kushwaha <pkushwaha@...vell.com>
To:     "yury.norov@...il.com" <yury.norov@...il.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "mirq-linux@...e.qmqm.pl" <mirq-linux@...e.qmqm.pl>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "David.Laight@...lab.com" <David.Laight@...lab.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "dennis@...nel.org" <dennis@...nel.org>,
        "kernel@...il.dk" <kernel@...il.dk>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "matti.vaittinen@...rohmeurope.com" 
        <matti.vaittinen@...rohmeurope.com>,
        "aklimov@...hat.com" <aklimov@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alok Prasad <palok@...vell.com>
Subject: RE: [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in
 qed_roce_stop()

Hi Yury,

> -----Original Message-----
> From: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Sent: Tuesday, February 15, 2022 10:41 AM
> To: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Subject: [PATCH 11/49] qed: replace bitmap_weight with
> bitmap_empty in qed_roce_stop()
> 
> Subject:  [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in
> qed_roce_stop()
> Date:  Thu, 10 Feb 2022 14:48:55 -0800
> From:  Yury Norov mailto:yury.norov@...il.com
> To:  Yury Norov mailto:yury.norov@...il.com, Andy Shevchenko
> mailto:andriy.shevchenko@...ux.intel.com, Rasmus Villemoes
> mailto:linux@...musvillemoes.dk, Andrew Morton mailto:akpm@...ux-
> foundation.org, Michał Mirosław mailto:mirq-linux@...e.qmqm.pl, Greg Kroah-
> Hartman mailto:gregkh@...uxfoundation.org, Peter Zijlstra
> mailto:peterz@...radead.org, David Laight mailto:David.Laight@...lab.com,
> Joe Perches mailto:joe@...ches.com, Dennis Zhou mailto:dennis@...nel.org,
> Emil Renner Berthing mailto:kernel@...il.dk, Nicholas Piggin
> mailto:npiggin@...il.com, Matti Vaittinen
> mailto:matti.vaittinen@...rohmeurope.com, Alexey Klimov
> mailto:aklimov@...hat.com, mailto:linux-kernel@...r.kernel.org, Ariel Elior
> mailto:aelior@...vell.com, Manish Chopra mailto:manishc@...vell.com,
> David S. Miller mailto:davem@...emloft.net, Jakub Kicinski
> mailto:kuba@...nel.org, mailto:netdev@...r.kernel.org
> 
> 
> qed_roce_stop() calls bitmap_weight() to check if any bit of a given
> bitmap is set. We can do it more efficiently with bitmap_empty() because
> bitmap_empty() stops traversing the bitmap as soon as it finds first set
> bit, while bitmap_weight() counts all bits unconditionally.
> 
> Signed-off-by: Yury Norov mailto:yury.norov@...il.com
> ---

Acked-by: Prabhakar Kushwaha <pkushwaha@...vell.com>