netdev - Re: [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220216095059.how2bexndwenhs6h@pali>
Date:   Wed, 16 Feb 2022 10:50:59 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Kalle Valo <kvalo@...eaurora.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        linux-mmc@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs

On Wednesday 16 February 2022 10:31:11 Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@...abs.com>
> 
> Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200
> are official SDIO IDs. However, it is not the case, the values used by
> WF200 are not official (BTW, the driver rely on the DT rather than on
> the SDIO IDs to probe the device).
> 
> To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use
> raw values.
> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

Reviewed-by: Pali Rohár <pali@...nel.org>

> ---
>  drivers/staging/wfx/bus_sdio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c
> index bc3df85a05b6..312d2d391a24 100644
> --- a/drivers/staging/wfx/bus_sdio.c
> +++ b/drivers/staging/wfx/bus_sdio.c
> @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func)
>  	sdio_release_host(func);
>  }
>  
> -#define SDIO_VENDOR_ID_SILABS        0x0000
> -#define SDIO_DEVICE_ID_SILABS_WF200  0x1000
>  static const struct sdio_device_id wfx_sdio_ids[] = {
> -	{ SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },
> +	/* WF200 does not have official VID/PID */
> +	{ SDIO_DEVICE(0x0000, 0x1000) },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
> -- 
> 2.34.1
>