netdev - Re: [PATCH v3 net-next 01/11] net: bridge: vlan: check early for lack of BRENTRY flag in br_vlan_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b64dd30-01c4-b6d5-0773-9d76916aa943@nvidia.com>
Date:   Wed, 16 Feb 2022 12:58:18 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, <netdev@...r.kernel.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        "Vivien Didelot" <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Roopa Prabhu <roopa@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Rafael Richter <rafael.richter@....de>,
        Daniel Klauer <daniel.klauer@....de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v3 net-next 01/11] net: bridge: vlan: check early for lack
 of BRENTRY flag in br_vlan_add_existing

On 15/02/2022 19:02, Vladimir Oltean wrote:
> When a VLAN is added to a bridge port, a master VLAN gets created on the
> bridge for context, but it doesn't have the BRENTRY flag.
> 
> Then, when the same VLAN is added to the bridge itself, that enters
> through the br_vlan_add_existing() code path and gains the BRENTRY flag,
> thus it becomes "existing".
> 
> It seems natural to check for this condition early, because the current
> code flow is to notify switchdev of the addition of a VLAN that isn't a
> brentry, just to delete it immediately afterwards.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> v2->v3: patch is new
> 
>  net/bridge/br_vlan.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>